empayre/fleet
14
0
Fork 0
mirror of https://github.com/empayre/fleet.git synced 2024-11-06 08:55:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug with Vendor Width migration (#7339)

Browse Source 
Updated migration used to increate the width of 'software.vendor' to
address issue found when running migration in aurora: "ALGORITHM=INPLACE is not
supported. Reason: cannot silently convert NULL values, as required in
this SQL_MODE. Try ALGORITHM=COPY."
This commit is contained in:
Juan Fernandez 2022-08-22 13:01:18 -04:00 committed by GitHub
parent e280c04c94
commit e6aba8caaa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
server/datastore/mysql/migrations/tables/20220818101352_ChangeSoftwareVendorWidth.go
View File

@ -17,7 +17,7 @@ func Up_20220818101352(tx *sql.Tx) error {
// Add temp column.
//-----------------
if _, err := tx.Exec(
`ALTER TABLE software ADD COLUMN vendor_wide varchar(114) NULL, ALGORITHM=INPLACE, LOCK=NONE`); err != nil {
`ALTER TABLE software ADD COLUMN vendor_wide varchar(114) DEFAULT '' NOT NULL, ALGORITHM=INPLACE, LOCK=NONE`); err != nil {
return errors.Wrapf(err, "creating temp column for vendor")
}
@ -30,21 +30,12 @@ func Up_20220818101352(tx *sql.Tx) error {
}
//------------------
// Update in batches
// Perform update
//------------------
const updateStmt = `UPDATE software SET vendor_wide = vendor WHERE vendor_wide IS NULL LIMIT 500`
for {
res, err := tx.Exec(updateStmt)
if err != nil {
return errors.Wrapf(err, "updating temp vendor column")
}
affected, err := res.RowsAffected()
if err != nil {
return errors.Wrapf(err, "updating temp vendor column")
}
if affected == 0 {
break
}
const updateStmt = `UPDATE software SET vendor_wide = vendor WHERE vendor <> ''`
_, err := tx.Exec(updateStmt)
if err != nil {
return errors.Wrapf(err, "updating temp vendor column")
}
//----------------
@ -58,15 +49,15 @@ func Up_20220818101352(tx *sql.Tx) error {
// Rename old column
//------------------
if _, err := tx.Exec(`ALTER TABLE software CHANGE vendor vendor_old varchar(32) DEFAULT '' NOT NULL, ALGORITHM=INPLACE, LOCK=NONE`); err != nil {
return errors.Wrapf(err, "dropping old column")
return errors.Wrapf(err, "renaming old column")
}
// ---------------
// Rename column
// Rename new column
// ---------------
if _, err := tx.Exec(
`ALTER TABLE software CHANGE vendor_wide vendor varchar(114) DEFAULT '' NOT NULL, ALGORITHM=INPLACE, LOCK=NONE`); err != nil {
return errors.Wrapf(err, "dropping old column")
return errors.Wrapf(err, "renaming new column")
}
logger.Info.Println("Done increasing width of software.vendor...")