empayre/fleet
14
0
Fork 0
mirror of https://github.com/empayre/fleet.git synced 2024-11-06 00:45:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Editor Pass - Add community PR guidelines (#5360)

Browse Source 
Editor pass for:  https://github.com/fleetdm/fleet/pull/5137

@mike-j-thomas We need to discuss what we're considering complete sentences and capitalization of items after a colon that complete the sentence. This page has a lot of examples of how we're currently doing it. It's grammatically incorrect, but just let me know if that's the style choice.
This commit is contained in:
Desmi-Dizney 2022-05-05 19:57:07 -05:00 committed by GitHub
parent 9631103c6e
commit 8c7d22e6ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handbook/community.md
View File

@ -218,13 +218,13 @@ When a new pull request is submitted by a community contributor (someone not a m
- If a review is needed:
- Request review from the [Product DRI](./product.md#product-dris). They should approve extensive changes and new features. Ask in the #g-product channel in Fleet's Slack for more information.
- Tag the DRI and the contributor in a comment on the PR, letting everyone know why an additional review is needed. Make sure to say thanks!
- Find any open issues that are related and make a note in the comments.
- Find any related open issues and make a note in the comments.
> Please refer to our [PRs from the community](https://docs.google.com/document/d/13r0vEhs9LOBdxWQWdZ8n5Ff9cyB3hQkTjI5OhcrHjVo/edit?usp=sharing) guide and use your best judgment.
#### Communicate with contributors
Community contributions are awesome, and it's important that the contributor knows how much they are appreciated. The best way to do that is to keep in touch while we're working to get their PR approved.
Community contributions are fantastic, and it's important that the contributor knows how much they are appreciated. The best way to do that is to keep in touch while we're working on getting their PR approved.
While each team member is responsible for monitoring their active issues and pull requests, the Community Engagement DRI will check in on pull requests with the `:community ` label daily to make sure everything is moving along. If there's a comment or question from the contributor that hasn't been addressed, reach out on Slack to get more information and update the contributor.
@ -236,7 +236,7 @@ When merging a pull request from a community contributor:
- Verify that all necessary reviews have been approved.
- Merge the PR.
- Thank and congratulate the contributor.
- Share the merged PR with the team in the #help-promote channel of Fleet Slack to be publicized on social media. Those who contribute to Fleet and are recognized for their contributions often become great champions for the project.
- Share the merged PR with the team in the #help-promote channel of Fleet Slack to be publicized on social media. Those who contribute to Fleet and are recognized for their contributions, often become great champions for the project.
### Reviewing PRs from the community