empayre/fleet
14
0
Fork 0
mirror of https://github.com/empayre/fleet.git synced 2024-11-06 08:55:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Adding custom action to WIX template to ensure files are not locked during uninstallation (#8871)

Browse Source 
* Adding custom action to ensure that no fleetdm related processes are running on a product uninstall scenario. This will ensure that no file locks are present during file removal
This commit is contained in:
Marcos Oviedo 2022-12-06 07:03:06 -03:00 committed by GitHub
parent a8fe6b4bec
commit 8796ce9a38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changes/bug-3563-uninstall-does-not-remove-files Normal file
View File

@ -0,0 +1 @@
* Windows installer now ensures that no files are left on the filesystem when orbit uninstallation process is kicked off

8
orbit/pkg/packaging/windows_templates.go
View File

@ -95,6 +95,14 @@ var windowsWixTemplate = template.Must(template.New("").Option("missingkey=error
</Directory>
</Directory>
<CustomAction Id="StopOrbit_cmd" Property="WixQuietExecCmdLine" Value='"[WindowsFolder]System32\taskkill.exe" /F /IM osqueryd.exe /IM fleet-desktop.exe /IM orbit.exe' />
<CustomAction Id="StopOrbit" BinaryKey="WixCA" DllEntry="WixQuietExec" Execute="immediate" Return="check"/>
<InstallExecuteSequence>
<Custom Action='StopOrbit_cmd' Before='RemoveFiles'>(NOT UPGRADINGPRODUCTCODE) AND (REMOVE="ALL")</Custom>
<Custom Action='StopOrbit' After='StopOrbit_cmd'>(NOT UPGRADINGPRODUCTCODE) AND (REMOVE="ALL")</Custom>
</InstallExecuteSequence>
<Feature Id="Orbit" Title="Fleet osquery" Level="1" Display="hidden">
<ComponentGroupRef Id="OrbitFiles" />
<ComponentRef Id="C_ORBITROOT_REMOVAL" />