Bump go to 1.19.1 (#7690)

* Bump go to 1.19.1

* Bump remaining go-version to the 1.19.1

* Add extra paths for test-go

* Oops, putting the right path in the right place

* gofmt file

* gofmt ALL THE THINGS

* Moar changes

* Actually, go.mod doesn't like minor versions

.github/workflows/build-and-push-fleetctl-docker.yml

@@ -31,7 +31,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: 1.17.8
+          go-version: 1.19.1
 
       - name: Install Go Dependencies
         run: make deps-go

.github/workflows/build-binaries.yaml

@@ -17,7 +17,7 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
       with:
-        go-version: 1.17
+        go-version: 1.19.1
 
     - name: Checkout Code
       uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v2

.github/workflows/fleet-and-orbit.yml

@@ -42,7 +42,7 @@ jobs:
     timeout-minutes: 60
     strategy:
       matrix:
-        go-version: ['^1.17.0']
+        go-version: ['^1.19.1']
         mysql: ['mysql:5.7']
     runs-on: ubuntu-latest
     needs: gen
@@ -132,7 +132,7 @@ jobs:
     timeout-minutes: 60
     strategy:
       matrix:
-        go-version: ['^1.17.0']
+        go-version: ['^1.19.1']
     runs-on: ubuntu-latest
     needs: gen
     steps:
@@ -180,7 +180,7 @@ jobs:
     timeout-minutes: 60
     strategy:
       matrix:
-        go-version: ['^1.17.0']
+        go-version: ['^1.19.1']
     # We can only generate all (PKG, MSI, DEB, RPM) packages from a macOS host.
     runs-on: macos-latest
     needs: gen

.github/workflows/fleetctl-preview-latest.yml

@@ -37,7 +37,7 @@ jobs:
       matrix:
         # Doesn't work on Windows because Linux Docker containers are not supported.
         os: [ubuntu-latest, macos-latest]
-        go-version: ['1.17.9']
+        go-version: ['1.19.1']
     runs-on: ${{ matrix.os }}
     steps:
 

.github/workflows/generate-desktop-targets.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: '^1.17.0'
+          go-version: '^1.19.1'
 
       - name: Checkout
         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v2
@@ -73,7 +73,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: '^1.17.0'
+          go-version: '^1.19.1'
 
       - name: Checkout
         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v2
@@ -96,7 +96,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: '^1.17.0'
+          go-version: '^1.19.1'
 
       - name: Checkout
         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v2

.github/workflows/golangci-lint.yml

@@ -9,6 +9,7 @@ on:
   pull_request:
     paths:
       - '**.go'
+      - '.github/workflows/golangci-lint.yml'
   workflow_dispatch: # Manual
 
 permissions:
@@ -26,7 +27,7 @@ jobs:
 
       - uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a
         with:
-          go-version: '1.17'
+          go-version: '1.19.1'
 
       - name: Run go lint
         run: |

.github/workflows/goreleaser-fleet.yaml

@@ -29,7 +29,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: 1.17.8
+          go-version: 1.19.1
 
       - name: Install JS Dependencies
         run: make deps-js

.github/workflows/goreleaser-orbit.yaml

@@ -42,7 +42,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: 1.19.0
+          go-version: 1.19.1
 
       - name: Run GoReleaser
         run: go run github.com/goreleaser/goreleaser@v1.9.2 release --rm-dist -f orbit/.goreleaser.yml

.github/workflows/goreleaser-snapshot-fleet.yaml

@@ -27,7 +27,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
         with:
-          go-version: 1.17.8
+          go-version: 1.19.1
 
       - name: Install Dependencies
         run: make deps

.github/workflows/test-go.yaml

@@ -14,6 +14,7 @@ on:
       - '**.go'
       - 'go.mod'
       - 'go.sum'
+      - '.github/workflows/test-go.yaml'
   workflow_dispatch: # Manual
   schedule:
     - cron: '0 4 * * *'
@@ -26,7 +27,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        go-version: ['^1.17.8']
+        go-version: ['^1.19.1']
         mysql: ["mysql:5.7.21", "mysql:8.0.28"]
     runs-on: ${{ matrix.os }}
 

.github/workflows/test-packaging.yml

@@ -33,7 +33,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest]
-        go-version: ['^1.17.8']
+        go-version: ['^1.19.1']
     runs-on: ${{ matrix.os }}
 
     steps:

.github/workflows/test-schema-changes.yml

@@ -22,7 +22,7 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a # v2
       with:
-        go-version: '^1.17.8'
+        go-version: '^1.19.1'
     - name: Checkout Code
       uses: actions/checkout@629c2de402a417ea7690ca6ce3f33229e27606a5 # v2
 

.github/workflows/test.yml

@@ -31,7 +31,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        go-version: ['^1.17.8']
+        go-version: ['^1.19.1']
         fleet-tier: [free, premium]
     runs-on: ${{ matrix.os }}
     steps:

Dockerfile-desktop-linux

@@ -1,4 +1,4 @@
-FROM --platform=linux/amd64 golang:1.19.0-bullseye
+FROM --platform=linux/amd64 golang:1.19.1-bullseye
 LABEL maintainer="Fleet Developers <hello@fleetdm.com>"
 
 RUN apt-get update && apt-get install -y \

Dockerfile.osquery-perf

@@ -1,4 +1,4 @@
-FROM golang:1.19.0-alpine
+FROM golang:1.19.1-alpine
 
 ARG ENROLL_SECRET
 ARG HOST_COUNT

infrastructure/loadtesting/terraform/docker/loadtest.Dockerfile

@@ -1,7 +1,7 @@
-FROM golang:1.19.0
+FROM golang:1.19.1
 ARG TAG
 RUN apt update && apt upgrade -y && apt install npm yarnpkg -y && ln -s /usr/bin/yarnpkg /usr/bin/yarn
 RUN git clone -b $TAG https://github.com/fleetdm/fleet.git && cd /go/fleet/cmd/osquery-perf/ && go build .
 
-FROM golang:1.19.0
+FROM golang:1.19.1
 COPY --from=0 /go/fleet/cmd/osquery-perf/osquery-perf /go/osquery-perf

infrastructure/sandbox/JITProvisioner/deprovisioner/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.19-alpine AS builder
+FROM golang:1.19.1-alpine AS builder
 RUN apk update && apk add --no-cache git curl openssl unzip
 WORKDIR /build
 COPY . .

infrastructure/sandbox/JITProvisioner/lambda/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.19-alpine AS builder
+FROM golang:1.19.1-alpine AS builder
 WORKDIR /build
 COPY . .
 RUN go get -d -v

infrastructure/sandbox/JITProvisioner/lambda/main.go

@@ -15,8 +15,8 @@ import (
 	"github.com/aws/aws-sdk-go/service/dynamodb"
 	"github.com/aws/aws-sdk-go/service/dynamodb/dynamodbattribute"
 	"github.com/aws/aws-sdk-go/service/sfn"
-	"github.com/fleetdm/fleet/v4/server/service"
 	"github.com/fleetdm/fleet/v4/pkg/spec"
+	"github.com/fleetdm/fleet/v4/server/service"
 	"github.com/loopfz/gadgeto/tonic"
 	"github.com/wI2L/fizz"
 	"github.com/wI2L/fizz/openapi"
@@ -24,9 +24,9 @@ import (
 	_ "go.elastic.co/apm/v2"
 	"log"
 	"math/rand"
+	"os"
 	"strings"
 	"time"
-	"os"
 )
 
 type OptionsStruct struct {
@@ -39,7 +39,7 @@ type OptionsStruct struct {
 
 var options = OptionsStruct{}
 
-func applyConfig(c* gin.Context, url, token string) (err error) {
+func applyConfig(c *gin.Context, url, token string) (err error) {
 	var client *service.Client
 	if client, err = service.NewClient(url, false, "", ""); err != nil {
 		log.Print(err)

infrastructure/sandbox/Monitoring/lambda/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.19-alpine AS builder
+FROM golang:1.19.1-alpine AS builder
 WORKDIR /build
 COPY . .
 RUN go get -d -v

infrastructure/sandbox/PreProvisioner/lambda/Dockerfile

@@ -6,7 +6,7 @@ RUN cargo install --version 0.16.0 apple-codesign \
   && curl -sSf $transporter_url -o transporter_install.sh \
   && sh transporter_install.sh --target transporter --accept --noexec
 
-FROM golang:1.19.0-bullseye
+FROM golang:1.19.1-bullseye
 
 RUN apt-get update \
   && dpkg --add-architecture i386 \

orbit/pkg/execuser/execuser_windows.go

@@ -99,11 +99,11 @@ const (
 // It sets the environment of the current process so that it gets inherited by
 // the child process (see call to CreateEnvironmentBlock).
 // From https://docs.microsoft.com/en-us/windows/win32/procthread/changing-environment-variables:
+//
 //	"If you want the child process to inherit most of the parent's environment with
 //	only a few changes, retrieve the current values using GetEnvironmentVariable, save these values,
 //	create an updated block for the child process to inherit, create the child process, and then
 //	restore the saved values using SetEnvironmentVariable, as shown in the following example."
-//
 func run(path string, opts eopts) error {
 	for _, nv := range opts.env {
 		os.Setenv(nv[0], nv[1])

orbit/pkg/packaging/macos_templates.go

@@ -70,7 +70,7 @@ launchctl kickstart "system/${DAEMON_LABEL}"
 
 // TODO set Nice?
 //
-//Note it's important not to start the orbit binary in
+// Note it's important not to start the orbit binary in
 // `/usr/local/bin/orbit` because this is a path that users usually have write
 // access to, and running that binary with launchd can become a privilege
 // escalation vector.

orbit/pkg/packaging/packaging.go

@@ -227,6 +227,7 @@ func writeOsqueryFlagfile(opt Options, orbitRoot string) error {
 
 // Embed the certs file that osquery uses so that we can drop it into our installation packages.
 // This file copied from https://raw.githubusercontent.com/osquery/osquery/master/tools/deployment/certs.pem
+//
 //go:embed certs.pem
 var osqueryCerts []byte
 

orbit/pkg/platform/platform_windows.go

@@ -1,4 +1,5 @@
-//+build windows
+//go:build windows
+// +build windows
 
 package platform
 

server/authz/authz.go

@@ -26,6 +26,7 @@ type Authorizer struct {
 }
 
 // Load the policy from policy.rego in this directory.
+//
 //go:embed policy.rego
 var policy string
 

server/datastore/mysql/policies.go

@@ -114,6 +114,7 @@ func (ds *Datastore) SavePolicy(ctx context.Context, p *fleet.Policy) error {
 //     and osquery agents bring in new failing results from them then those will be returned here
 //     (in newFailing or newPassing).
 //   - Similar in case a host was deleted.
+//
 // Trying to filter those out here would make this operation more expensive (fetch policies from the
 // `policies` table and querying the `hosts` table).
 func (ds *Datastore) FlippingPoliciesForHost(

server/live_query/redis_live_query.go

@@ -1,7 +1,7 @@
 // Package live_query implements an interface for storing and
 // retrieving live queries.
 //
-// Design
+// # Design
 //
 // This package operates by storing a single redis key for host
 // targeting information. This key has a known prefix, and the data
@@ -21,7 +21,7 @@
 // number of live queries targeting all of them. This was a big
 // factor in choosing this implementation.
 //
-// Implementation
+// # Implementation
 //
 // As mentioned in the Design section, there are three keys for each
 // live query: the bitfield, the SQL of the query and the set containing
@@ -42,7 +42,6 @@
 // live on a single node in cluster mode (a "hot key"), and that node will see
 // increased activity due to that. Should that become a significant problem, an
 // alternative approach will be required.
-//
 package live_query
 
 import (
@@ -84,6 +83,7 @@ func generateKeys(name string) (targetsKey, sqlKey string) {
 }
 
 // returns the base name part of a target key, i.e. so that this is true:
+//
 //	tkey, _ := generateKeys(name)
 //	baseName := extractTargetKeyName(tkey)
 //	baseName == name

server/service/devices.go

@@ -9,9 +9,9 @@ import (
 	"github.com/fleetdm/fleet/v4/server/fleet"
 )
 
-/////////////////////////////////////////////////////////////////////////////////
+// ///////////////////////////////////////////////////////////////////////////////
 // Fleet Desktop endpoints
-/////////////////////////////////////////////////////////////////////////////////
+// ///////////////////////////////////////////////////////////////////////////////
 type getFleetDesktopResponse struct {
 	Err             error `json:"error,omitempty"`
 	FailingPolicies *uint `json:"failing_policies_count,omitempty"`

server/vulnerabilities/oval/mappers.go

@@ -72,12 +72,16 @@ func mapCriteria(i oval_input.CriteriaXML) (*oval_parsed.Criteria, error) {
 // Test objects can define their 'name' in one of two ways:
 // 1. Inline:
 // <:object ...>
+//
 //	<:name>software name</:name>
+//
 // </:object>
 //
 // 2. As a variable reference:
 // <:object ...>
+//
 //	<:name var_ref="var:200224390000000" var_check="at least one" />
+//
 // </:object>
 func mapPackageInfoTestObject(
 	obj oval_input.PackageInfoTestObjectXML,

server/vulnerabilities/oval/parsed/dpkg_infotest.go

@@ -35,6 +35,7 @@ func (t *DpkgInfoTest) Eval(packages []fleet.Software) ([]fleet.Software, error)
 }
 
 // Returns:
+//
 //	nObjects: How many items in the set defined by the OVAL Object set exists in the system.
 //	nStates: How many items in the set defined by the OVAL Object set satisfy the state requirements.
 //	Slice with software matching both the object and state criteria.

server/vulnerabilities/oval/parsed/rpm_infotest.go

@@ -35,6 +35,7 @@ func (t *RpmInfoTest) Eval(packages []fleet.Software) ([]fleet.Software, error)
 }
 
 // Returns:
+//
 //	nObjects: How many items in the set defined by the OVAL Object set exists in the system.
 //	nStates: How many items in the set defined by the OVAL Object set satisfy the state requirements.
 //	Slice with software matching both the object and state criteria.

server/vulnerabilities/oval/parsed/rpmvercmp.go

@@ -15,6 +15,7 @@ import (
 //   - RELEASEs are compared using the rpmvercmp algo, if equal then both are equal.
 //
 // Returns:
+//
 //	-1 if a < b
 //	0 if a == b
 //	1 if a > b

tools/redis-tests/tlsconnect.go

@@ -3,13 +3,13 @@
 // the configuration get properly passed down to the pool creation.
 //
 // To run a TLS redis server:
-//     * Build redis from source with `make BUILD_TLS=yes` (https://redis.io/topics/encryption)
+//   - Build redis from source with `make BUILD_TLS=yes` (https://redis.io/topics/encryption)
-//     * Generate certificates and keys with `./utils/gen-test-certs.sh`
+//   - Generate certificates and keys with `./utils/gen-test-certs.sh`
 //     (the generated files will be under ./tests/tls/)
-//     * Run `./src/redis-server --tls-port 7379 --port 0 --tls-ca-cert-file
+//   - Run `./src/redis-server --tls-port 7379 --port 0 --tls-ca-cert-file
 //     ./tests/tls/ca.crt --tls-cert-file ./tests/tls/redis.crt --tls-key-file
 //     ./tests/tls/redis.key`
-//     * Run this command to test connection, e.g.:
+//   - Run this command to test connection, e.g.:
 //     `go run ./tools/redis-tests/tlsconnect.go -- -addr localhost:7379 -cacert ./tests/tls/ca.crt
 //     -cert ./tests/tls/redis.crt -key ./tests/tls/redis.key PING` -skip
 package main