diff --git a/frontend/components/forms/fields/SelectTargetsDropdown/SelectTargetsMenu/_styles.scss b/frontend/components/forms/fields/SelectTargetsDropdown/SelectTargetsMenu/_styles.scss index b829f82fc..4b13cd1c5 100644 --- a/frontend/components/forms/fields/SelectTargetsDropdown/SelectTargetsMenu/_styles.scss +++ b/frontend/components/forms/fields/SelectTargetsDropdown/SelectTargetsMenu/_styles.scss @@ -1,5 +1,4 @@ .target-list { - background-color: $ui-light-grey; &__type { padding: 0 8px 4px; diff --git a/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.jsx b/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.jsx index c7acf68f7..5604ecb5a 100644 --- a/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.jsx +++ b/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.jsx @@ -5,7 +5,7 @@ import AceEditor from 'react-ace'; import classnames from 'classnames'; import hostHelpers from 'components/hosts/HostsTable/helpers'; -import Icon from 'components/icons/Icon'; +import KolideIcon from 'components/icons/KolideIcon'; import PlatformIcon from 'components/icons/PlatformIcon'; import targetInterface from 'interfaces/target'; @@ -60,16 +60,16 @@ class TargetDetails extends Component { return (

- + {displayText}

- {isOnline && } - {isOffline && } + {isOnline && } + {isOffline && } {status}

@@ -123,11 +123,11 @@ class TargetDetails extends Component { return (

- + {displayText}

diff --git a/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.tests.jsx b/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.tests.jsx index 6bfeb9786..f015b0bdb 100644 --- a/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.tests.jsx +++ b/frontend/components/forms/fields/SelectTargetsDropdown/TargetDetails/TargetDetails.tests.jsx @@ -48,9 +48,9 @@ describe('TargetDetails - component', () => { it('renders a success check icon when the target is online', () => { const target = { ...Test.Stubs.hostStub, status: 'online' }; const Component = mount(); - const Icon = Component.find('Icon'); - const onlineIcon = Icon.find('.host-target__icon--online'); - const offlineIcon = Icon.find('.host-target__icon--offline'); + const KolideIcon = Component.find('KolideIcon'); + const onlineIcon = KolideIcon.find('.host-target__icon--online'); + const offlineIcon = KolideIcon.find('.host-target__icon--offline'); expect(onlineIcon.length).toBeGreaterThan(0, 'Expected the online icon to render'); expect(offlineIcon.length).toEqual(0, 'Expected the offline icon to not render'); @@ -59,9 +59,9 @@ describe('TargetDetails - component', () => { it('renders a offline icon when the target is offline', () => { const target = { ...Test.Stubs.hostStub, status: 'offline' }; const Component = mount(); - const Icon = Component.find('Icon'); - const onlineIcon = Icon.find('.host-target__icon--online'); - const offlineIcon = Icon.find('.host-target__icon--offline'); + const KolideIcon = Component.find('KolideIcon'); + const onlineIcon = KolideIcon.find('.host-target__icon--online'); + const offlineIcon = KolideIcon.find('.host-target__icon--offline'); expect(onlineIcon.length).toEqual(0, 'Expected the online icon to not render'); expect(offlineIcon.length).toBeGreaterThan(0, 'Expected the offline icon to render'); diff --git a/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss b/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss index 98c174caf..f7673739a 100644 --- a/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss +++ b/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss @@ -108,7 +108,7 @@ .Select-menu { height: 498px; max-height: 498px; - overflow: hidden; + overflow: scroll; position: relative; &::after {