2022-10-05 22:53:54 +00:00
|
|
|
package service
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"context"
|
2023-01-31 14:46:01 +00:00
|
|
|
"crypto/tls"
|
2023-02-17 19:26:51 +00:00
|
|
|
"encoding/base64"
|
2023-01-23 23:05:24 +00:00
|
|
|
"fmt"
|
2022-10-05 22:53:54 +00:00
|
|
|
"net/http"
|
|
|
|
"net/http/httptest"
|
2023-01-31 14:46:01 +00:00
|
|
|
"os"
|
2022-10-05 22:53:54 +00:00
|
|
|
"strings"
|
2023-01-23 23:05:24 +00:00
|
|
|
"sync/atomic"
|
2022-10-05 22:53:54 +00:00
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/fleetdm/fleet/v4/server/authz"
|
|
|
|
"github.com/fleetdm/fleet/v4/server/config"
|
2023-02-15 18:01:44 +00:00
|
|
|
"github.com/fleetdm/fleet/v4/server/contexts/license"
|
2023-01-23 23:05:24 +00:00
|
|
|
"github.com/fleetdm/fleet/v4/server/contexts/viewer"
|
2022-10-05 22:53:54 +00:00
|
|
|
"github.com/fleetdm/fleet/v4/server/fleet"
|
|
|
|
"github.com/fleetdm/fleet/v4/server/mock"
|
2023-01-31 14:46:01 +00:00
|
|
|
nanodep_mock "github.com/fleetdm/fleet/v4/server/mock/nanodep"
|
|
|
|
nanomdm_mock "github.com/fleetdm/fleet/v4/server/mock/nanomdm"
|
2023-01-23 23:05:24 +00:00
|
|
|
"github.com/fleetdm/fleet/v4/server/ptr"
|
2022-10-05 22:53:54 +00:00
|
|
|
"github.com/fleetdm/fleet/v4/server/test"
|
2023-01-31 14:46:01 +00:00
|
|
|
kitlog "github.com/go-kit/kit/log"
|
2023-02-15 18:01:44 +00:00
|
|
|
"github.com/google/uuid"
|
2022-10-05 22:53:54 +00:00
|
|
|
nanodep_client "github.com/micromdm/nanodep/client"
|
|
|
|
"github.com/micromdm/nanomdm/mdm"
|
2023-01-31 14:46:01 +00:00
|
|
|
nanomdm_pushsvc "github.com/micromdm/nanomdm/push/service"
|
2022-10-05 22:53:54 +00:00
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
)
|
|
|
|
|
2023-01-31 14:46:01 +00:00
|
|
|
func setupAppleMDMService(t *testing.T) (fleet.Service, context.Context, *mock.Store) {
|
2022-10-05 22:53:54 +00:00
|
|
|
ds := new(mock.Store)
|
|
|
|
cfg := config.TestConfig()
|
2023-02-15 18:01:44 +00:00
|
|
|
cfg.MDMApple.Enable = true
|
2022-10-05 22:53:54 +00:00
|
|
|
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
switch {
|
|
|
|
case strings.Contains(r.URL.Path, "/server/devices"):
|
2022-12-05 22:50:49 +00:00
|
|
|
_, err := w.Write([]byte("{}"))
|
|
|
|
require.NoError(t, err)
|
2022-10-05 22:53:54 +00:00
|
|
|
return
|
|
|
|
case strings.Contains(r.URL.Path, "/session"):
|
2022-12-05 22:50:49 +00:00
|
|
|
_, err := w.Write([]byte(`{"auth_session_token": "yoo"}`))
|
|
|
|
require.NoError(t, err)
|
2022-10-05 22:53:54 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}))
|
2023-01-23 23:05:24 +00:00
|
|
|
|
2023-01-31 14:46:01 +00:00
|
|
|
mdmStorage := &nanomdm_mock.Storage{}
|
|
|
|
depStorage := &nanodep_mock.Storage{}
|
|
|
|
pushFactory, _ := newMockAPNSPushProviderFactory()
|
|
|
|
pusher := nanomdm_pushsvc.New(
|
|
|
|
mdmStorage,
|
|
|
|
mdmStorage,
|
|
|
|
pushFactory,
|
|
|
|
NewNanoMDMLogger(kitlog.NewJSONLogger(os.Stdout)),
|
|
|
|
)
|
|
|
|
|
2023-01-23 23:05:24 +00:00
|
|
|
opts := &TestServerOpts{
|
2022-10-05 22:53:54 +00:00
|
|
|
FleetConfig: &cfg,
|
2023-01-31 14:46:01 +00:00
|
|
|
MDMStorage: mdmStorage,
|
|
|
|
DEPStorage: depStorage,
|
|
|
|
MDMPusher: pusher,
|
2023-02-15 18:01:44 +00:00
|
|
|
License: &fleet.LicenseInfo{Tier: fleet.TierPremium},
|
2023-01-31 14:46:01 +00:00
|
|
|
}
|
|
|
|
svc, ctx := newTestServiceWithConfig(t, ds, cfg, nil, nil, opts)
|
|
|
|
|
|
|
|
mdmStorage.EnqueueCommandFunc = func(ctx context.Context, id []string, cmd *mdm.Command) (map[string]error, error) {
|
|
|
|
return nil, nil
|
2023-01-23 23:05:24 +00:00
|
|
|
}
|
2023-01-31 14:46:01 +00:00
|
|
|
mdmStorage.RetrievePushInfoFunc = func(ctx context.Context, tokens []string) (map[string]*mdm.Push, error) {
|
|
|
|
res := make(map[string]*mdm.Push, len(tokens))
|
|
|
|
for _, t := range tokens {
|
|
|
|
res[t] = &mdm.Push{
|
|
|
|
PushMagic: "",
|
|
|
|
Token: []byte(t),
|
|
|
|
Topic: "",
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return res, nil
|
2023-01-23 23:05:24 +00:00
|
|
|
}
|
2023-01-31 14:46:01 +00:00
|
|
|
mdmStorage.RetrievePushCertFunc = func(ctx context.Context, topic string) (*tls.Certificate, string, error) {
|
|
|
|
cert, err := tls.LoadX509KeyPair("testdata/server.pem", "testdata/server.key")
|
|
|
|
return &cert, "", err
|
2023-01-23 23:05:24 +00:00
|
|
|
}
|
2023-01-31 14:46:01 +00:00
|
|
|
mdmStorage.IsPushCertStaleFunc = func(ctx context.Context, topic string, staleToken string) (bool, error) {
|
|
|
|
return false, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
depStorage.RetrieveAuthTokensFunc = func(ctx context.Context, name string) (*nanodep_client.OAuth1Tokens, error) {
|
|
|
|
return &nanodep_client.OAuth1Tokens{}, nil
|
|
|
|
}
|
|
|
|
depStorage.RetrieveConfigFunc = func(context.Context, string) (*nanodep_client.Config, error) {
|
|
|
|
return &nanodep_client.Config{
|
|
|
|
BaseURL: ts.URL,
|
|
|
|
}, nil
|
2023-01-23 23:05:24 +00:00
|
|
|
}
|
|
|
|
|
2022-10-05 22:53:54 +00:00
|
|
|
ds.AppConfigFunc = func(ctx context.Context) (*fleet.AppConfig, error) {
|
|
|
|
return &fleet.AppConfig{
|
|
|
|
OrgInfo: fleet.OrgInfo{
|
|
|
|
OrgName: "Foo Inc.",
|
|
|
|
},
|
|
|
|
ServerSettings: fleet.ServerSettings{
|
|
|
|
ServerURL: "https://foo.example.com",
|
|
|
|
},
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
ds.GetMDMAppleEnrollmentProfileByTokenFunc = func(ctx context.Context, token string) (*fleet.MDMAppleEnrollmentProfile, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.NewMDMAppleEnrollmentProfileFunc = func(ctx context.Context, enrollmentPayload fleet.MDMAppleEnrollmentProfilePayload) (*fleet.MDMAppleEnrollmentProfile, error) {
|
|
|
|
return &fleet.MDMAppleEnrollmentProfile{
|
|
|
|
ID: 1,
|
|
|
|
Token: "foo",
|
|
|
|
Type: fleet.MDMAppleEnrollmentTypeManual,
|
|
|
|
EnrollmentURL: "https://foo.example.com?token=foo",
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
ds.GetMDMAppleEnrollmentProfileByTokenFunc = func(ctx context.Context, token string) (*fleet.MDMAppleEnrollmentProfile, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.ListMDMAppleEnrollmentProfilesFunc = func(ctx context.Context) ([]*fleet.MDMAppleEnrollmentProfile, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.GetMDMAppleCommandResultsFunc = func(ctx context.Context, commandUUID string) (map[string]*fleet.MDMAppleCommandResult, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.NewMDMAppleInstallerFunc = func(ctx context.Context, name string, size int64, manifest string, installer []byte, urlToken string) (*fleet.MDMAppleInstaller, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.MDMAppleInstallerFunc = func(ctx context.Context, token string) (*fleet.MDMAppleInstaller, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.MDMAppleInstallerDetailsByIDFunc = func(ctx context.Context, id uint) (*fleet.MDMAppleInstaller, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.DeleteMDMAppleInstallerFunc = func(ctx context.Context, id uint) error {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
ds.MDMAppleInstallerDetailsByTokenFunc = func(ctx context.Context, token string) (*fleet.MDMAppleInstaller, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.ListMDMAppleInstallersFunc = func(ctx context.Context) ([]fleet.MDMAppleInstaller, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.MDMAppleListDevicesFunc = func(ctx context.Context) ([]fleet.MDMAppleDevice, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
2023-01-23 23:05:24 +00:00
|
|
|
ds.GetNanoMDMEnrollmentStatusFunc = func(ctx context.Context, hostUUID string) (bool, error) {
|
|
|
|
return false, nil
|
|
|
|
}
|
|
|
|
|
2023-01-16 20:06:30 +00:00
|
|
|
return svc, ctx, ds
|
2022-10-05 22:53:54 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestAppleMDMAuthorization(t *testing.T) {
|
2023-01-31 14:46:01 +00:00
|
|
|
svc, ctx, _ := setupAppleMDMService(t)
|
2022-10-05 22:53:54 +00:00
|
|
|
|
|
|
|
checkAuthErr := func(t *testing.T, err error, shouldFailWithAuth bool) {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
if shouldFailWithAuth {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.Contains(t, err.Error(), authz.ForbiddenErrorMessage)
|
|
|
|
} else {
|
|
|
|
require.NoError(t, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
testAuthdMethods := func(t *testing.T, user *fleet.User, shouldFailWithAuth bool) {
|
2022-11-15 14:08:05 +00:00
|
|
|
ctx := test.UserContext(ctx, user)
|
2022-10-05 22:53:54 +00:00
|
|
|
_, err := svc.NewMDMAppleEnrollmentProfile(ctx, fleet.MDMAppleEnrollmentProfilePayload{})
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.ListMDMAppleEnrollmentProfiles(ctx)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.GetMDMAppleCommandResults(ctx, "foo")
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.UploadMDMAppleInstaller(ctx, "foo", 3, bytes.NewReader([]byte("foo")))
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.GetMDMAppleInstallerByID(ctx, 42)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
err = svc.DeleteMDMAppleInstaller(ctx, 42)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.ListMDMAppleInstallers(ctx)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.ListMDMAppleDevices(ctx)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, err = svc.ListMDMAppleDEPDevices(ctx)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
_, _, err = svc.EnqueueMDMAppleCommand(ctx, &fleet.MDMAppleCommand{Command: &mdm.Command{}}, nil, false)
|
|
|
|
checkAuthErr(t, err, shouldFailWithAuth)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Only global admins can access the endpoints.
|
|
|
|
testAuthdMethods(t, test.UserAdmin, false)
|
|
|
|
|
|
|
|
// All other users should not have access to the endpoints.
|
|
|
|
for _, user := range []*fleet.User{
|
|
|
|
test.UserNoRoles,
|
|
|
|
test.UserMaintainer,
|
|
|
|
test.UserObserver,
|
|
|
|
test.UserTeamAdminTeam1,
|
|
|
|
} {
|
|
|
|
testAuthdMethods(t, user, true)
|
|
|
|
}
|
|
|
|
// Token authenticated endpoints can be accessed by anyone.
|
2022-11-15 14:08:05 +00:00
|
|
|
ctx = test.UserContext(ctx, test.UserNoRoles)
|
2022-10-05 22:53:54 +00:00
|
|
|
_, err := svc.GetMDMAppleInstallerByToken(ctx, "foo")
|
|
|
|
require.NoError(t, err)
|
|
|
|
_, err = svc.GetMDMAppleEnrollmentProfileByToken(ctx, "foo")
|
|
|
|
require.NoError(t, err)
|
|
|
|
_, err = svc.GetMDMAppleInstallerDetailsByToken(ctx, "foo")
|
|
|
|
require.NoError(t, err)
|
2022-12-19 13:37:08 +00:00
|
|
|
// Generating a new key pair does not actually make any changes to fleet, or expose any
|
|
|
|
// information. The user must configure fleet with the new key pair and restart the server.
|
|
|
|
_, err = svc.NewMDMAppleDEPKeyPair(ctx)
|
|
|
|
require.NoError(t, err)
|
2023-01-16 15:22:12 +00:00
|
|
|
|
|
|
|
// Must be device-authenticated, should fail
|
|
|
|
_, err = svc.GetDeviceMDMAppleEnrollmentProfile(ctx)
|
|
|
|
checkAuthErr(t, err, true)
|
|
|
|
// works with device-authenticated context
|
|
|
|
ctx = test.HostContext(context.Background(), &fleet.Host{})
|
|
|
|
_, err = svc.GetDeviceMDMAppleEnrollmentProfile(ctx)
|
|
|
|
require.NoError(t, err)
|
2022-10-05 22:53:54 +00:00
|
|
|
}
|
2022-12-23 17:55:17 +00:00
|
|
|
|
|
|
|
func TestMDMAppleEnrollURL(t *testing.T) {
|
|
|
|
svc := Service{}
|
|
|
|
|
|
|
|
cases := []struct {
|
|
|
|
appConfig *fleet.AppConfig
|
|
|
|
expectedURL string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
appConfig: &fleet.AppConfig{
|
|
|
|
ServerSettings: fleet.ServerSettings{
|
|
|
|
ServerURL: "https://foo.example.com",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
expectedURL: "https://foo.example.com/api/mdm/apple/enroll?token=tok",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
appConfig: &fleet.AppConfig{
|
|
|
|
ServerSettings: fleet.ServerSettings{
|
|
|
|
ServerURL: "https://foo.example.com/",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
expectedURL: "https://foo.example.com/api/mdm/apple/enroll?token=tok",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tt := range cases {
|
|
|
|
enrollURL, err := svc.mdmAppleEnrollURL("tok", tt.appConfig)
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, tt.expectedURL, enrollURL)
|
|
|
|
}
|
|
|
|
}
|
2023-01-16 20:06:30 +00:00
|
|
|
|
2023-02-17 15:28:28 +00:00
|
|
|
func TestMDMAppleConfigProfileAuthz(t *testing.T) {
|
|
|
|
svc, ctx, ds := setupAppleMDMService(t)
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
name string
|
|
|
|
user *fleet.User
|
|
|
|
shouldFailGlobal bool
|
|
|
|
shouldFailTeam bool
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
"global admin",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
false,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global observer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleObserver)},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, belongs to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, belongs to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, belongs to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"user no roles",
|
|
|
|
&fleet.User{ID: 1337},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.NewMDMAppleConfigProfileFunc = func(ctx context.Context, cp fleet.MDMAppleConfigProfile) (*fleet.MDMAppleConfigProfile, error) {
|
|
|
|
return &cp, nil
|
|
|
|
}
|
|
|
|
ds.ListMDMAppleConfigProfilesFunc = func(ctx context.Context, teamID *uint) ([]*fleet.MDMAppleConfigProfile, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.NewActivityFunc = func(context.Context, *fleet.User, fleet.ActivityDetails) error {
|
|
|
|
return nil
|
|
|
|
}
|
2023-03-02 00:36:59 +00:00
|
|
|
ds.GetMDMAppleHostsProfilesSummaryFunc = func(context.Context, *uint) (*fleet.MDMAppleHostsProfilesSummary, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
2023-02-17 15:28:28 +00:00
|
|
|
mockGetFuncWithTeamID := func(teamID uint) mock.GetMDMAppleConfigProfileFunc {
|
|
|
|
return func(ctx context.Context, profileID uint) (*fleet.MDMAppleConfigProfile, error) {
|
|
|
|
require.Equal(t, uint(42), profileID)
|
|
|
|
return &fleet.MDMAppleConfigProfile{TeamID: &teamID}, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
mockDeleteFuncWithTeamID := func(teamID uint) mock.DeleteMDMAppleConfigProfileFunc {
|
|
|
|
return func(ctx context.Context, profileID uint) error {
|
|
|
|
require.Equal(t, uint(42), profileID)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
mockTeamFuncWithUser := func(u *fleet.User) mock.TeamFunc {
|
|
|
|
return func(ctx context.Context, teamID uint) (*fleet.Team, error) {
|
|
|
|
if len(u.Teams) > 0 {
|
|
|
|
for _, t := range u.Teams {
|
|
|
|
if t.ID == teamID {
|
|
|
|
return &fleet.Team{ID: teamID, Users: []fleet.TeamUser{{User: *u, Role: t.Role}}}, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return &fleet.Team{}, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
checkShouldFail := func(err error, shouldFail bool) {
|
|
|
|
if !shouldFail {
|
|
|
|
require.NoError(t, err)
|
|
|
|
} else {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.Contains(t, err.Error(), authz.ForbiddenErrorMessage)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mcBytes := mcBytesForTest("Foo", "Bar", "UUID")
|
|
|
|
|
|
|
|
for _, tt := range testCases {
|
|
|
|
ctx := viewer.NewContext(ctx, viewer.Viewer{User: tt.user})
|
|
|
|
ds.TeamFunc = mockTeamFuncWithUser(tt.user)
|
|
|
|
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
|
|
// test authz create new profile (no team)
|
|
|
|
_, err := svc.NewMDMAppleConfigProfile(ctx, 0, bytes.NewReader(mcBytes), int64(len(mcBytes)))
|
|
|
|
checkShouldFail(err, tt.shouldFailGlobal)
|
|
|
|
|
|
|
|
// test authz create new profile (team 1)
|
|
|
|
_, err = svc.NewMDMAppleConfigProfile(ctx, 1, bytes.NewReader(mcBytes), int64(len(mcBytes)))
|
|
|
|
checkShouldFail(err, tt.shouldFailTeam)
|
|
|
|
|
|
|
|
// test authz list profiles (no team)
|
|
|
|
_, err = svc.ListMDMAppleConfigProfiles(ctx, 0)
|
|
|
|
checkShouldFail(err, tt.shouldFailGlobal)
|
|
|
|
|
|
|
|
// test authz list profiles (team 1)
|
|
|
|
_, err = svc.ListMDMAppleConfigProfiles(ctx, 1)
|
|
|
|
checkShouldFail(err, tt.shouldFailTeam)
|
|
|
|
|
|
|
|
// test authz get config profile (no team)
|
|
|
|
ds.GetMDMAppleConfigProfileFunc = mockGetFuncWithTeamID(0)
|
|
|
|
_, err = svc.GetMDMAppleConfigProfile(ctx, 42)
|
|
|
|
checkShouldFail(err, tt.shouldFailGlobal)
|
|
|
|
|
|
|
|
// test authz delete config profile (no team)
|
|
|
|
ds.DeleteMDMAppleConfigProfileFunc = mockDeleteFuncWithTeamID(0)
|
|
|
|
err = svc.DeleteMDMAppleConfigProfile(ctx, 42)
|
|
|
|
checkShouldFail(err, tt.shouldFailGlobal)
|
|
|
|
|
|
|
|
// test authz get config profile (team 1)
|
|
|
|
ds.GetMDMAppleConfigProfileFunc = mockGetFuncWithTeamID(1)
|
|
|
|
_, err = svc.GetMDMAppleConfigProfile(ctx, 42)
|
|
|
|
checkShouldFail(err, tt.shouldFailTeam)
|
|
|
|
|
|
|
|
// test authz delete config profile (team 1)
|
|
|
|
ds.DeleteMDMAppleConfigProfileFunc = mockDeleteFuncWithTeamID(1)
|
|
|
|
err = svc.DeleteMDMAppleConfigProfile(ctx, 42)
|
|
|
|
checkShouldFail(err, tt.shouldFailTeam)
|
2023-03-02 00:36:59 +00:00
|
|
|
|
|
|
|
// test authz get profiles summary (no team)
|
|
|
|
_, err = svc.GetMDMAppleProfilesSummary(ctx, nil)
|
|
|
|
checkShouldFail(err, tt.shouldFailGlobal)
|
|
|
|
|
|
|
|
// test authz get profiles summary (no team)
|
|
|
|
_, err = svc.GetMDMAppleProfilesSummary(ctx, ptr.Uint(1))
|
|
|
|
checkShouldFail(err, tt.shouldFailTeam)
|
2023-02-17 15:28:28 +00:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestNewMDMAppleConfigProfile(t *testing.T) {
|
|
|
|
svc, ctx, ds := setupAppleMDMService(t)
|
|
|
|
ctx = viewer.NewContext(ctx, viewer.Viewer{User: &fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)}})
|
|
|
|
|
|
|
|
mcBytes := mcBytesForTest("Foo", "Bar", "UUID")
|
|
|
|
r := bytes.NewReader(mcBytes)
|
|
|
|
|
|
|
|
ds.NewMDMAppleConfigProfileFunc = func(ctx context.Context, cp fleet.MDMAppleConfigProfile) (*fleet.MDMAppleConfigProfile, error) {
|
|
|
|
require.Equal(t, "Foo", cp.Name)
|
|
|
|
require.Equal(t, "Bar", cp.Identifier)
|
|
|
|
require.Equal(t, mcBytes, []byte(cp.Mobileconfig))
|
|
|
|
cp.ProfileID = 1
|
|
|
|
return &cp, nil
|
|
|
|
}
|
|
|
|
ds.NewActivityFunc = func(context.Context, *fleet.User, fleet.ActivityDetails) error {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
cp, err := svc.NewMDMAppleConfigProfile(ctx, 0, r, r.Size())
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, "Foo", cp.Name)
|
|
|
|
require.Equal(t, "Bar", cp.Identifier)
|
|
|
|
require.Equal(t, mcBytes, []byte(cp.Mobileconfig))
|
|
|
|
}
|
|
|
|
|
|
|
|
func mcBytesForTest(name, identifier, uuid string) []byte {
|
|
|
|
return []byte(fmt.Sprintf(`<?xml version="1.0" encoding="UTF-8"?>
|
|
|
|
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
|
|
|
<plist version="1.0">
|
|
|
|
<dict>
|
|
|
|
<key>PayloadContent</key>
|
|
|
|
<array/>
|
|
|
|
<key>PayloadDisplayName</key>
|
|
|
|
<string>%s</string>
|
|
|
|
<key>PayloadIdentifier</key>
|
|
|
|
<string>%s</string>
|
|
|
|
<key>PayloadType</key>
|
|
|
|
<string>Configuration</string>
|
|
|
|
<key>PayloadUUID</key>
|
|
|
|
<string>%s</string>
|
|
|
|
<key>PayloadVersion</key>
|
|
|
|
<integer>1</integer>
|
|
|
|
</dict>
|
|
|
|
</plist>
|
|
|
|
`, name, identifier, uuid))
|
|
|
|
}
|
|
|
|
|
2023-02-22 22:26:06 +00:00
|
|
|
func TestHostDetailsMDMProfiles(t *testing.T) {
|
|
|
|
svc, ctx, ds := setupAppleMDMService(t)
|
|
|
|
ctx = viewer.NewContext(ctx, viewer.Viewer{User: &fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)}})
|
|
|
|
|
|
|
|
expected := []fleet.HostMDMAppleProfile{
|
2023-02-23 13:27:00 +00:00
|
|
|
{HostUUID: "H057-UU1D-1337", Name: "NAME-5", ProfileID: uint(5), CommandUUID: "CMD-UU1D-5", Status: &fleet.MDMAppleDeliveryPending, OperationType: fleet.MDMAppleOperationTypeInstall, Detail: ""},
|
|
|
|
{HostUUID: "H057-UU1D-1337", Name: "NAME-9", ProfileID: uint(8), CommandUUID: "CMD-UU1D-8", Status: &fleet.MDMAppleDeliveryApplied, OperationType: fleet.MDMAppleOperationTypeInstall, Detail: ""},
|
|
|
|
{HostUUID: "H057-UU1D-1337", Name: "NAME-13", ProfileID: uint(13), CommandUUID: "CMD-UU1D-13", Status: &fleet.MDMAppleDeliveryFailed, OperationType: fleet.MDMAppleOperationTypeRemove, Detail: "Error removing profile"},
|
2023-02-22 22:26:06 +00:00
|
|
|
}
|
|
|
|
expectedByProfileID := make(map[uint]fleet.HostMDMAppleProfile)
|
|
|
|
for _, ep := range expected {
|
|
|
|
expectedByProfileID[ep.ProfileID] = ep
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.GetHostMDMProfilesFunc = func(ctx context.Context, hostUUID string) ([]fleet.HostMDMAppleProfile, error) {
|
|
|
|
if hostUUID == "H057-UU1D-1337" {
|
|
|
|
return expected, nil
|
|
|
|
}
|
|
|
|
return []fleet.HostMDMAppleProfile{}, nil
|
|
|
|
}
|
|
|
|
ds.HostFunc = func(ctx context.Context, hostID uint) (*fleet.Host, error) {
|
|
|
|
if hostID == uint(42) {
|
|
|
|
return &fleet.Host{ID: uint(42), UUID: "H057-UU1D-1337"}, nil
|
|
|
|
}
|
|
|
|
return &fleet.Host{ID: hostID, UUID: "WR0N6-UU1D"}, nil
|
|
|
|
}
|
|
|
|
ds.HostByIdentifierFunc = func(ctx context.Context, identifier string) (*fleet.Host, error) {
|
|
|
|
if identifier == "h0571d3n71f13r" {
|
|
|
|
return &fleet.Host{ID: uint(42), UUID: "H057-UU1D-1337"}, nil
|
|
|
|
}
|
|
|
|
return &fleet.Host{ID: uint(21), UUID: "WR0N6-UU1D"}, nil
|
|
|
|
}
|
|
|
|
ds.LoadHostSoftwareFunc = func(ctx context.Context, host *fleet.Host, includeCVEScores bool) error {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
ds.ListLabelsForHostFunc = func(ctx context.Context, hid uint) ([]*fleet.Label, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.ListPacksForHostFunc = func(ctx context.Context, hid uint) (packs []*fleet.Pack, err error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.ListHostBatteriesFunc = func(ctx context.Context, id uint) ([]*fleet.HostBattery, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
ds.ListPoliciesForHostFunc = func(ctx context.Context, host *fleet.Host) ([]*fleet.HostPolicy, error) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
2023-02-23 13:27:00 +00:00
|
|
|
expectedNilSlice := []fleet.HostMDMAppleProfile(nil)
|
|
|
|
expectedEmptySlice := []fleet.HostMDMAppleProfile{}
|
|
|
|
|
2023-02-22 22:26:06 +00:00
|
|
|
cases := []struct {
|
|
|
|
name string
|
|
|
|
mdmEnabled bool
|
|
|
|
hostID *uint
|
|
|
|
hostIdentifier *string
|
|
|
|
expected *[]fleet.HostMDMAppleProfile
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
name: "TestGetHostMDMProfilesOK",
|
|
|
|
mdmEnabled: true,
|
|
|
|
hostID: ptr.Uint(42),
|
|
|
|
hostIdentifier: nil,
|
|
|
|
expected: &expected,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "TestGetHostMDMProfilesEmpty",
|
2023-02-23 13:27:00 +00:00
|
|
|
mdmEnabled: true,
|
2023-02-22 22:26:06 +00:00
|
|
|
hostID: ptr.Uint(21),
|
|
|
|
hostIdentifier: nil,
|
2023-02-23 13:27:00 +00:00
|
|
|
expected: &expectedEmptySlice,
|
2023-02-22 22:26:06 +00:00
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "TestGetHostMDMProfilesNil",
|
|
|
|
mdmEnabled: false,
|
|
|
|
hostID: ptr.Uint(42),
|
|
|
|
hostIdentifier: nil,
|
2023-02-23 13:27:00 +00:00
|
|
|
expected: &expectedNilSlice,
|
2023-02-22 22:26:06 +00:00
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "TestHostByIdentifierMDMProfilesOK",
|
|
|
|
mdmEnabled: true,
|
|
|
|
hostID: nil,
|
|
|
|
hostIdentifier: ptr.String("h0571d3n71f13r"),
|
|
|
|
expected: &expected,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "TestHostByIdentifierMDMProfilesNil",
|
|
|
|
mdmEnabled: false,
|
|
|
|
hostID: nil,
|
|
|
|
hostIdentifier: ptr.String("h0571d3n71f13r"),
|
2023-02-23 13:27:00 +00:00
|
|
|
expected: &expectedNilSlice,
|
2023-02-22 22:26:06 +00:00
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "TestHostByIdentifierMDMProfilesEmpty",
|
2023-02-23 13:27:00 +00:00
|
|
|
mdmEnabled: true,
|
2023-02-22 22:26:06 +00:00
|
|
|
hostID: nil,
|
|
|
|
hostIdentifier: ptr.String("4n07h3r1d3n71f13r"),
|
2023-02-23 13:27:00 +00:00
|
|
|
expected: &expectedEmptySlice,
|
2023-02-22 22:26:06 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range cases {
|
|
|
|
t.Run(c.name, func(t *testing.T) {
|
|
|
|
ds.AppConfigFunc = func(context.Context) (*fleet.AppConfig, error) {
|
|
|
|
return &fleet.AppConfig{MDM: fleet.MDM{EnabledAndConfigured: c.mdmEnabled}}, nil
|
|
|
|
}
|
|
|
|
ds.AppConfigFuncInvoked = false
|
|
|
|
ds.HostFuncInvoked = false
|
|
|
|
ds.HostByIdentifierFuncInvoked = false
|
|
|
|
ds.GetHostMDMProfilesFuncInvoked = false
|
|
|
|
|
|
|
|
var gotHost *fleet.HostDetail
|
|
|
|
if c.hostID != nil {
|
|
|
|
h, err := svc.GetHost(ctx, *c.hostID, fleet.HostDetailOptions{})
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, ds.HostFuncInvoked)
|
|
|
|
gotHost = h
|
|
|
|
}
|
|
|
|
if c.hostIdentifier != nil {
|
|
|
|
h, err := svc.HostByIdentifier(ctx, *c.hostIdentifier, fleet.HostDetailOptions{})
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, ds.HostByIdentifierFuncInvoked)
|
|
|
|
gotHost = h
|
|
|
|
}
|
|
|
|
require.NotNil(t, gotHost)
|
|
|
|
require.True(t, ds.AppConfigFuncInvoked)
|
|
|
|
|
|
|
|
if !c.mdmEnabled {
|
2023-02-23 13:27:00 +00:00
|
|
|
require.Equal(t, gotHost.MDM.Profiles, c.expected)
|
2023-02-22 22:26:06 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
require.True(t, ds.GetHostMDMProfilesFuncInvoked)
|
|
|
|
require.NotNil(t, gotHost.MDM.Profiles)
|
|
|
|
require.ElementsMatch(t, *c.expected, *gotHost.MDM.Profiles)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-01-16 20:06:30 +00:00
|
|
|
func TestAppleMDMEnrollmentProfile(t *testing.T) {
|
2023-01-31 14:46:01 +00:00
|
|
|
svc, ctx, _ := setupAppleMDMService(t)
|
2023-01-16 20:06:30 +00:00
|
|
|
|
|
|
|
// Only global admins can create enrollment profiles.
|
|
|
|
ctx = test.UserContext(ctx, test.UserAdmin)
|
|
|
|
_, err := svc.NewMDMAppleEnrollmentProfile(ctx, fleet.MDMAppleEnrollmentProfilePayload{})
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
// All other users should not have access to the endpoints.
|
|
|
|
for _, user := range []*fleet.User{
|
|
|
|
test.UserNoRoles,
|
|
|
|
test.UserMaintainer,
|
|
|
|
test.UserObserver,
|
|
|
|
test.UserTeamAdminTeam1,
|
|
|
|
} {
|
|
|
|
ctx := test.UserContext(ctx, user)
|
|
|
|
_, err := svc.NewMDMAppleEnrollmentProfile(ctx, fleet.MDMAppleEnrollmentProfilePayload{})
|
|
|
|
require.Error(t, err)
|
|
|
|
require.Contains(t, err.Error(), authz.ForbiddenErrorMessage)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-01-23 23:05:24 +00:00
|
|
|
func TestMDMCommandAuthz(t *testing.T) {
|
2023-01-31 14:46:01 +00:00
|
|
|
svc, ctx, ds := setupAppleMDMService(t)
|
2023-01-23 23:05:24 +00:00
|
|
|
|
|
|
|
ds.HostLiteFunc = func(ctx context.Context, hostID uint) (*fleet.Host, error) {
|
|
|
|
switch hostID {
|
|
|
|
case 1:
|
|
|
|
return &fleet.Host{UUID: "test-host-team-1", TeamID: ptr.Uint(1)}, nil
|
|
|
|
default:
|
|
|
|
return &fleet.Host{UUID: "test-host-no-team"}, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.GetHostMDMCheckinInfoFunc = func(ctx context.Context, hostUUID string) (*fleet.HostMDMCheckinInfo, error) {
|
|
|
|
return &fleet.HostMDMCheckinInfo{}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.NewActivityFunc = func(context.Context, *fleet.User, fleet.ActivityDetails) error {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
var mdmEnabled atomic.Bool
|
|
|
|
ds.GetNanoMDMEnrollmentStatusFunc = func(ctx context.Context, hostUUID string) (bool, error) {
|
|
|
|
// This function is called twice during EnqueueMDMAppleCommandRemoveEnrollmentProfile.
|
|
|
|
// It first is called to check that the device is enrolled as a pre-condition to enqueueing the
|
|
|
|
// command. It is called second time after the command has been enqueued to check whether
|
|
|
|
// the device was successfully unenrolled.
|
|
|
|
//
|
|
|
|
// For each test run, the bool should be initialized to true to simulate an existing device
|
|
|
|
// that is initially enrolled to Fleet's MDM.
|
|
|
|
return mdmEnabled.Swap(!mdmEnabled.Load()), nil
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
name string
|
|
|
|
user *fleet.User
|
|
|
|
shouldFailGlobal bool
|
|
|
|
shouldFailTeam bool
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
"global admin",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
false,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global observer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleObserver)},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, belongs to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, belongs to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
false,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, belongs to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"user no roles",
|
|
|
|
&fleet.User{ID: 1337},
|
|
|
|
true,
|
|
|
|
true,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tt := range testCases {
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
|
|
ctx := viewer.NewContext(ctx, viewer.Viewer{User: tt.user})
|
|
|
|
|
|
|
|
mdmEnabled.Store(true)
|
|
|
|
err := svc.EnqueueMDMAppleCommandRemoveEnrollmentProfile(ctx, 42) // global host
|
|
|
|
if !tt.shouldFailGlobal {
|
|
|
|
require.NoError(t, err)
|
|
|
|
} else {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.Contains(t, err.Error(), authz.ForbiddenErrorMessage)
|
|
|
|
}
|
|
|
|
|
|
|
|
mdmEnabled.Store(true)
|
|
|
|
err = svc.EnqueueMDMAppleCommandRemoveEnrollmentProfile(ctx, 1) // host belongs to team 1
|
|
|
|
if !tt.shouldFailTeam {
|
|
|
|
require.NoError(t, err)
|
|
|
|
} else {
|
|
|
|
require.Error(t, err)
|
|
|
|
require.Contains(t, err.Error(), authz.ForbiddenErrorMessage)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-01-16 20:06:30 +00:00
|
|
|
func TestMDMAuthenticate(t *testing.T) {
|
|
|
|
ds := new(mock.Store)
|
|
|
|
svc := MDMAppleCheckinAndCommandService{ds: ds}
|
|
|
|
ctx := context.Background()
|
|
|
|
uuid, serial, model := "ABC-DEF-GHI", "XYZABC", "MacBookPro 16,1"
|
|
|
|
|
|
|
|
ds.IngestMDMAppleDeviceFromCheckinFunc = func(ctx context.Context, mdmHost fleet.MDMAppleHostDetails) error {
|
|
|
|
require.Equal(t, uuid, mdmHost.UDID)
|
|
|
|
require.Equal(t, serial, mdmHost.SerialNumber)
|
|
|
|
require.Equal(t, model, mdmHost.Model)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.GetHostMDMCheckinInfoFunc = func(ct context.Context, hostUUID string) (*fleet.HostMDMCheckinInfo, error) {
|
|
|
|
require.Equal(t, uuid, hostUUID)
|
2023-01-23 23:05:24 +00:00
|
|
|
return &fleet.HostMDMCheckinInfo{HardwareSerial: serial, DisplayName: fmt.Sprintf("%s (%s)", model, serial), InstalledFromDEP: false}, nil
|
2023-01-16 20:06:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
ds.NewActivityFunc = func(ctx context.Context, user *fleet.User, activity fleet.ActivityDetails) error {
|
|
|
|
a, ok := activity.(*fleet.ActivityTypeMDMEnrolled)
|
|
|
|
require.True(t, ok)
|
|
|
|
require.Nil(t, user)
|
|
|
|
require.Equal(t, "mdm_enrolled", activity.ActivityName())
|
|
|
|
require.Equal(t, serial, a.HostSerial)
|
2023-01-23 23:05:24 +00:00
|
|
|
require.Equal(t, a.HostDisplayName, fmt.Sprintf("%s (%s)", model, serial))
|
2023-01-16 20:06:30 +00:00
|
|
|
require.False(t, a.InstalledFromDEP)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
err := svc.Authenticate(
|
|
|
|
&mdm.Request{Context: ctx},
|
|
|
|
&mdm.Authenticate{
|
|
|
|
Enrollment: mdm.Enrollment{
|
|
|
|
UDID: uuid,
|
|
|
|
},
|
|
|
|
SerialNumber: serial,
|
|
|
|
Model: model,
|
|
|
|
},
|
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, ds.IngestMDMAppleDeviceFromCheckinFuncInvoked)
|
|
|
|
require.True(t, ds.GetHostMDMCheckinInfoFuncInvoked)
|
|
|
|
require.True(t, ds.NewActivityFuncInvoked)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestMDMCheckout(t *testing.T) {
|
|
|
|
ds := new(mock.Store)
|
|
|
|
svc := MDMAppleCheckinAndCommandService{ds: ds}
|
|
|
|
ctx := context.Background()
|
2023-01-23 23:05:24 +00:00
|
|
|
uuid, serial, installedFromDEP, displayName := "ABC-DEF-GHI", "XYZABC", true, "Test's MacBook"
|
2023-01-16 20:06:30 +00:00
|
|
|
|
|
|
|
ds.UpdateHostTablesOnMDMUnenrollFunc = func(ctx context.Context, hostUUID string) error {
|
|
|
|
require.Equal(t, uuid, hostUUID)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.GetHostMDMCheckinInfoFunc = func(ct context.Context, hostUUID string) (*fleet.HostMDMCheckinInfo, error) {
|
|
|
|
require.Equal(t, uuid, hostUUID)
|
|
|
|
return &fleet.HostMDMCheckinInfo{
|
|
|
|
HardwareSerial: serial,
|
2023-01-23 23:05:24 +00:00
|
|
|
DisplayName: displayName,
|
2023-01-16 20:06:30 +00:00
|
|
|
InstalledFromDEP: installedFromDEP,
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.NewActivityFunc = func(ctx context.Context, user *fleet.User, activity fleet.ActivityDetails) error {
|
|
|
|
a, ok := activity.(*fleet.ActivityTypeMDMUnenrolled)
|
|
|
|
require.True(t, ok)
|
|
|
|
require.Nil(t, user)
|
|
|
|
require.Equal(t, "mdm_unenrolled", activity.ActivityName())
|
|
|
|
require.Equal(t, serial, a.HostSerial)
|
2023-01-23 23:05:24 +00:00
|
|
|
require.Equal(t, displayName, a.HostDisplayName)
|
2023-01-16 20:06:30 +00:00
|
|
|
require.True(t, a.InstalledFromDEP)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
err := svc.CheckOut(
|
|
|
|
&mdm.Request{Context: ctx},
|
|
|
|
&mdm.CheckOut{
|
|
|
|
Enrollment: mdm.Enrollment{
|
|
|
|
UDID: uuid,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, ds.UpdateHostTablesOnMDMUnenrollFuncInvoked)
|
|
|
|
require.True(t, ds.GetHostMDMCheckinInfoFuncInvoked)
|
|
|
|
require.True(t, ds.NewActivityFuncInvoked)
|
|
|
|
}
|
2023-02-15 18:01:44 +00:00
|
|
|
|
2023-02-22 17:49:06 +00:00
|
|
|
func TestMDMCommandAndReportResultsProfileHandling(t *testing.T) {
|
|
|
|
ds := new(mock.Store)
|
|
|
|
svc := MDMAppleCheckinAndCommandService{ds: ds}
|
|
|
|
ctx := context.Background()
|
|
|
|
hostUUID := "ABC-DEF-GHI"
|
|
|
|
commandUUID := "COMMAND-UUID"
|
|
|
|
|
|
|
|
cases := []struct {
|
|
|
|
status string
|
|
|
|
requestType string
|
|
|
|
errors []mdm.ErrorChain
|
|
|
|
want *fleet.HostMDMAppleProfile
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
status: "Acknowledged",
|
|
|
|
requestType: "InstallProfile",
|
|
|
|
errors: nil,
|
|
|
|
want: &fleet.HostMDMAppleProfile{
|
|
|
|
Status: &fleet.MDMAppleDeliveryApplied,
|
|
|
|
Detail: "",
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeInstall,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
status: "Acknowledged",
|
|
|
|
requestType: "RemoveProfile",
|
|
|
|
errors: nil,
|
|
|
|
want: &fleet.HostMDMAppleProfile{
|
|
|
|
Status: &fleet.MDMAppleDeliveryApplied,
|
|
|
|
Detail: "",
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeRemove,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
status: "Error",
|
|
|
|
requestType: "InstallProfile",
|
|
|
|
errors: []mdm.ErrorChain{
|
|
|
|
{ErrorCode: 123, ErrorDomain: "testDomain", USEnglishDescription: "testMessage"},
|
|
|
|
},
|
|
|
|
want: &fleet.HostMDMAppleProfile{
|
|
|
|
Status: &fleet.MDMAppleDeliveryFailed,
|
|
|
|
Detail: "testDomain (123): testMessage\n",
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeInstall,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
status: "Error",
|
|
|
|
requestType: "RemoveProfile",
|
|
|
|
errors: []mdm.ErrorChain{
|
|
|
|
{ErrorCode: 123, ErrorDomain: "testDomain", USEnglishDescription: "testMessage"},
|
|
|
|
{ErrorCode: 321, ErrorDomain: "domainTest", USEnglishDescription: "messageTest"},
|
|
|
|
},
|
|
|
|
want: &fleet.HostMDMAppleProfile{
|
|
|
|
Status: &fleet.MDMAppleDeliveryFailed,
|
|
|
|
Detail: "testDomain (123): testMessage\ndomainTest (321): messageTest\n",
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeRemove,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
status: "Error",
|
|
|
|
requestType: "RemoveProfile",
|
|
|
|
errors: nil,
|
|
|
|
want: &fleet.HostMDMAppleProfile{
|
|
|
|
Status: &fleet.MDMAppleDeliveryFailed,
|
|
|
|
Detail: "",
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeRemove,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range cases {
|
|
|
|
ds.GetMDMAppleCommandRequestTypeFunc = func(ctx context.Context, targetCmd string) (string, error) {
|
|
|
|
require.Equal(t, commandUUID, targetCmd)
|
|
|
|
return c.requestType, nil
|
|
|
|
}
|
|
|
|
|
2023-03-08 20:42:23 +00:00
|
|
|
ds.UpdateOrDeleteHostMDMAppleProfileFunc = func(ctx context.Context, profile *fleet.HostMDMAppleProfile) error {
|
2023-02-22 17:49:06 +00:00
|
|
|
c.want.CommandUUID = commandUUID
|
|
|
|
c.want.HostUUID = hostUUID
|
|
|
|
require.Equal(t, c.want, profile)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
_, err := svc.CommandAndReportResults(
|
|
|
|
&mdm.Request{Context: ctx},
|
|
|
|
&mdm.CommandResults{
|
|
|
|
Enrollment: mdm.Enrollment{UDID: hostUUID},
|
|
|
|
CommandUUID: commandUUID,
|
|
|
|
Status: c.status,
|
|
|
|
RequestType: c.requestType,
|
|
|
|
ErrorChain: c.errors,
|
|
|
|
},
|
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, ds.GetMDMAppleCommandRequestTypeFuncInvoked)
|
2023-03-08 20:42:23 +00:00
|
|
|
require.True(t, ds.UpdateOrDeleteHostMDMAppleProfileFuncInvoked)
|
2023-02-22 17:49:06 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-02-15 18:01:44 +00:00
|
|
|
func TestMDMBatchSetAppleProfiles(t *testing.T) {
|
|
|
|
svc, ctx, ds := setupAppleMDMService(t)
|
|
|
|
|
|
|
|
ds.TeamByNameFunc = func(ctx context.Context, name string) (*fleet.Team, error) {
|
|
|
|
return &fleet.Team{ID: 1, Name: name}, nil
|
|
|
|
}
|
2023-02-16 16:53:26 +00:00
|
|
|
ds.TeamFunc = func(ctx context.Context, id uint) (*fleet.Team, error) {
|
|
|
|
return &fleet.Team{ID: id, Name: "team"}, nil
|
|
|
|
}
|
2023-02-15 18:01:44 +00:00
|
|
|
ds.BatchSetMDMAppleProfilesFunc = func(ctx context.Context, teamID *uint, profiles []*fleet.MDMAppleConfigProfile) error {
|
|
|
|
return nil
|
|
|
|
}
|
2023-02-16 16:53:26 +00:00
|
|
|
ds.NewActivityFunc = func(ctx context.Context, user *fleet.User, activity fleet.ActivityDetails) error {
|
|
|
|
return nil
|
|
|
|
}
|
2023-02-15 18:01:44 +00:00
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
name string
|
|
|
|
user *fleet.User
|
|
|
|
premium bool
|
|
|
|
teamID *uint
|
|
|
|
teamName *string
|
|
|
|
profiles [][]byte
|
|
|
|
wantErr string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
"global admin",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global admin, team",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer, team",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global observer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleObserver)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES belong to team by name",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
nil,
|
|
|
|
ptr.String("team"),
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES NOT belong to team by name",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
nil,
|
|
|
|
ptr.String("team"),
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, DOES belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, DOES belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"user no roles",
|
|
|
|
&fleet.User{ID: 1337},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team id with free license",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
ErrMissingLicense.Error(),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team name with free license",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
ptr.String("team"),
|
|
|
|
nil,
|
|
|
|
ErrMissingLicense.Error(),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team id and name specified",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
ptr.String("team"),
|
|
|
|
nil,
|
|
|
|
"cannot specify both team_id and team_name",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"duplicate profile name",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
[][]byte{
|
|
|
|
mobileconfigForTest("N1", "I1"),
|
|
|
|
mobileconfigForTest("N1", "I2"),
|
|
|
|
},
|
|
|
|
`More than one configuration profile have the same name (PayloadDisplayName): "N1"`,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"duplicate profile identifier",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
nil,
|
|
|
|
[][]byte{
|
|
|
|
mobileconfigForTest("N1", "I1"),
|
|
|
|
mobileconfigForTest("N2", "I2"),
|
|
|
|
mobileconfigForTest("N3", "I1"),
|
|
|
|
},
|
|
|
|
`More than one configuration profile have the same identifier (PayloadIdentifier): "I1"`,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"no duplicates",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
[][]byte{
|
|
|
|
mobileconfigForTest("N1", "I1"),
|
|
|
|
mobileconfigForTest("N2", "I2"),
|
|
|
|
mobileconfigForTest("N3", "I3"),
|
|
|
|
},
|
|
|
|
``,
|
|
|
|
},
|
2023-02-24 20:12:53 +00:00
|
|
|
{
|
|
|
|
"unsupported payload type",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
[][]byte{[]byte(`<?xml version="1.0" encoding="UTF-8"?>
|
|
|
|
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
|
|
|
<plist version="1.0">
|
|
|
|
<dict>
|
|
|
|
<key>PayloadContent</key>
|
|
|
|
<array>
|
|
|
|
<dict>
|
|
|
|
<key>Enable</key>
|
|
|
|
<string>On</string>
|
|
|
|
<key>PayloadDisplayName</key>
|
|
|
|
<string>FileVault 2</string>
|
|
|
|
<key>PayloadIdentifier</key>
|
|
|
|
<string>com.apple.MCX.FileVault2.A5874654-D6BA-4649-84B5-43847953B369</string>
|
|
|
|
<key>PayloadType</key>
|
|
|
|
<string>com.apple.MCX.FileVault2</string>
|
|
|
|
<key>PayloadUUID</key>
|
|
|
|
<string>A5874654-D6BA-4649-84B5-43847953B369</string>
|
|
|
|
<key>PayloadVersion</key>
|
|
|
|
<integer>1</integer>
|
|
|
|
</dict>
|
|
|
|
</array>
|
|
|
|
<key>PayloadDisplayName</key>
|
|
|
|
<string>Config Profile Name</string>
|
|
|
|
<key>PayloadIdentifier</key>
|
|
|
|
<string>com.example.config.FE42D0A2-DBA9-4B72-BC67-9288665B8D59</string>
|
|
|
|
<key>PayloadType</key>
|
|
|
|
<string>Configuration</string>
|
|
|
|
<key>PayloadUUID</key>
|
|
|
|
<string>FE42D0A2-DBA9-4B72-BC67-9288665B8D59</string>
|
|
|
|
<key>PayloadVersion</key>
|
|
|
|
<integer>1</integer>
|
|
|
|
</dict>
|
|
|
|
</plist>`)},
|
|
|
|
"unsupported PayloadType(s)",
|
|
|
|
},
|
2023-02-15 18:01:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, tt := range testCases {
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
|
|
defer func() { ds.BatchSetMDMAppleProfilesFuncInvoked = false }()
|
|
|
|
|
|
|
|
// prepare the context with the user and license
|
|
|
|
ctx := viewer.NewContext(ctx, viewer.Viewer{User: tt.user})
|
|
|
|
tier := fleet.TierFree
|
|
|
|
if tt.premium {
|
|
|
|
tier = fleet.TierPremium
|
|
|
|
}
|
|
|
|
ctx = license.NewContext(ctx, &fleet.LicenseInfo{Tier: tier})
|
|
|
|
|
|
|
|
err := svc.BatchSetMDMAppleProfiles(ctx, tt.teamID, tt.teamName, tt.profiles, false)
|
|
|
|
if tt.wantErr == "" {
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, ds.BatchSetMDMAppleProfilesFuncInvoked)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
require.Error(t, err)
|
|
|
|
require.ErrorContains(t, err, tt.wantErr)
|
|
|
|
require.False(t, ds.BatchSetMDMAppleProfilesFuncInvoked)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-03-06 14:54:51 +00:00
|
|
|
func TestUpdateMDMAppleSettings(t *testing.T) {
|
|
|
|
svc, ctx, ds := setupAppleMDMService(t)
|
|
|
|
|
|
|
|
ds.TeamFunc = func(ctx context.Context, id uint) (*fleet.Team, error) {
|
|
|
|
return &fleet.Team{ID: id, Name: "team"}, nil
|
|
|
|
}
|
|
|
|
ds.SaveTeamFunc = func(ctx context.Context, team *fleet.Team) (*fleet.Team, error) {
|
|
|
|
return team, nil
|
|
|
|
}
|
|
|
|
ds.NewActivityFunc = func(ctx context.Context, user *fleet.User, activity fleet.ActivityDetails) error {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
ds.AppConfigFunc = func(ctx context.Context) (*fleet.AppConfig, error) {
|
|
|
|
return &fleet.AppConfig{}, nil
|
|
|
|
}
|
|
|
|
ds.SaveAppConfigFunc = func(ctx context.Context, appConfig *fleet.AppConfig) error {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
name string
|
|
|
|
user *fleet.User
|
|
|
|
premium bool
|
|
|
|
teamID *uint
|
|
|
|
wantErr string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
"global admin",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
ErrMissingLicense.Error(),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global admin premium",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
true,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global admin, team",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
false,
|
|
|
|
nil,
|
|
|
|
ErrMissingLicense.Error(),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer premium",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
true,
|
|
|
|
nil,
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global maintainer, team",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleMaintainer)},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"global observer",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleObserver)},
|
|
|
|
true,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team admin, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleAdmin}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, DOES belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
"",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team maintainer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleMaintainer}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, DOES belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 1}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team observer, DOES NOT belong to team",
|
|
|
|
&fleet.User{Teams: []fleet.UserTeam{{Team: fleet.Team{ID: 2}, Role: fleet.RoleObserver}}},
|
|
|
|
true,
|
|
|
|
ptr.Uint(1),
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"user no roles",
|
|
|
|
&fleet.User{ID: 1337},
|
|
|
|
true,
|
|
|
|
nil,
|
|
|
|
authz.ForbiddenErrorMessage,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"team id with free license",
|
|
|
|
&fleet.User{GlobalRole: ptr.String(fleet.RoleAdmin)},
|
|
|
|
false,
|
|
|
|
ptr.Uint(1),
|
|
|
|
ErrMissingLicense.Error(),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tt := range testCases {
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
|
|
// prepare the context with the user and license
|
|
|
|
ctx := viewer.NewContext(ctx, viewer.Viewer{User: tt.user})
|
|
|
|
tier := fleet.TierFree
|
|
|
|
if tt.premium {
|
|
|
|
tier = fleet.TierPremium
|
|
|
|
}
|
|
|
|
ctx = license.NewContext(ctx, &fleet.LicenseInfo{Tier: tier})
|
|
|
|
|
|
|
|
err := svc.UpdateMDMAppleSettings(ctx, fleet.MDMAppleSettingsPayload{TeamID: tt.teamID})
|
|
|
|
if tt.wantErr == "" {
|
|
|
|
require.NoError(t, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
require.Error(t, err)
|
|
|
|
require.ErrorContains(t, err, tt.wantErr)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-02-17 19:26:51 +00:00
|
|
|
func TestMDMAppleCommander(t *testing.T) {
|
|
|
|
ctx := context.Background()
|
|
|
|
mdmStorage := &nanomdm_mock.Storage{}
|
|
|
|
pushFactory, _ := newMockAPNSPushProviderFactory()
|
|
|
|
pusher := nanomdm_pushsvc.New(
|
|
|
|
mdmStorage,
|
|
|
|
mdmStorage,
|
|
|
|
pushFactory,
|
|
|
|
NewNanoMDMLogger(kitlog.NewJSONLogger(os.Stdout)),
|
|
|
|
)
|
|
|
|
cmdr := NewMDMAppleCommander(mdmStorage, pusher)
|
|
|
|
|
|
|
|
// TODO(roberto): there's a data race in the mock when more
|
|
|
|
// than one host ID is provided because the pusher uses one
|
|
|
|
// goroutine per uuid to send the commands
|
|
|
|
hostUUIDs := []string{"A"}
|
|
|
|
payloadName := "com.foo.bar"
|
|
|
|
payloadIdentifier := "com-foo-bar"
|
|
|
|
mc := mobileconfigForTest(payloadName, payloadIdentifier)
|
|
|
|
|
|
|
|
mdmStorage.EnqueueCommandFunc = func(ctx context.Context, id []string, cmd *mdm.Command) (map[string]error, error) {
|
|
|
|
require.NotNil(t, cmd)
|
|
|
|
require.Equal(t, cmd.Command.RequestType, "InstallProfile")
|
|
|
|
require.Contains(t, string(cmd.Raw), base64.StdEncoding.EncodeToString(mc))
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
mdmStorage.RetrievePushInfoFunc = func(p0 context.Context, targetUUIDs []string) (map[string]*mdm.Push, error) {
|
|
|
|
require.ElementsMatch(t, hostUUIDs, targetUUIDs)
|
|
|
|
pushes := make(map[string]*mdm.Push, len(targetUUIDs))
|
|
|
|
for _, uuid := range targetUUIDs {
|
|
|
|
pushes[uuid] = &mdm.Push{
|
|
|
|
PushMagic: "magic" + uuid,
|
|
|
|
Token: []byte("token" + uuid),
|
|
|
|
Topic: "topic" + uuid,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return pushes, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
mdmStorage.RetrievePushCertFunc = func(ctx context.Context, topic string) (*tls.Certificate, string, error) {
|
|
|
|
cert, err := tls.LoadX509KeyPair("testdata/server.pem", "testdata/server.key")
|
|
|
|
return &cert, "", err
|
|
|
|
}
|
|
|
|
mdmStorage.IsPushCertStaleFunc = func(ctx context.Context, topic string, staleToken string) (bool, error) {
|
|
|
|
return false, nil
|
|
|
|
}
|
|
|
|
|
2023-02-22 17:49:06 +00:00
|
|
|
cmdUUID := uuid.New().String()
|
|
|
|
err := cmdr.InstallProfile(ctx, hostUUIDs, mc, cmdUUID)
|
|
|
|
require.NotEmpty(t, cmdUUID)
|
2023-02-17 19:26:51 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, mdmStorage.EnqueueCommandFuncInvoked)
|
|
|
|
mdmStorage.EnqueueCommandFuncInvoked = false
|
|
|
|
require.True(t, mdmStorage.RetrievePushInfoFuncInvoked)
|
|
|
|
mdmStorage.RetrievePushInfoFuncInvoked = false
|
|
|
|
|
|
|
|
mdmStorage.EnqueueCommandFunc = func(ctx context.Context, id []string, cmd *mdm.Command) (map[string]error, error) {
|
|
|
|
require.NotNil(t, cmd)
|
|
|
|
require.Equal(t, "RemoveProfile", cmd.Command.RequestType)
|
|
|
|
require.Contains(t, string(cmd.Raw), payloadIdentifier)
|
|
|
|
return nil, nil
|
|
|
|
}
|
2023-02-22 17:49:06 +00:00
|
|
|
cmdUUID = uuid.New().String()
|
|
|
|
err = cmdr.RemoveProfile(ctx, hostUUIDs, payloadIdentifier, cmdUUID)
|
2023-02-17 19:26:51 +00:00
|
|
|
require.True(t, mdmStorage.EnqueueCommandFuncInvoked)
|
|
|
|
mdmStorage.EnqueueCommandFuncInvoked = false
|
|
|
|
require.True(t, mdmStorage.RetrievePushInfoFuncInvoked)
|
|
|
|
mdmStorage.RetrievePushInfoFuncInvoked = false
|
2023-02-22 17:49:06 +00:00
|
|
|
require.NotEmpty(t, cmdUUID)
|
|
|
|
require.NoError(t, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestMDMAppleReconcileProfiles(t *testing.T) {
|
|
|
|
ctx := context.Background()
|
|
|
|
mdmStorage := &nanomdm_mock.Storage{}
|
|
|
|
ds := new(mock.Store)
|
|
|
|
pushFactory, _ := newMockAPNSPushProviderFactory()
|
|
|
|
pusher := nanomdm_pushsvc.New(
|
|
|
|
mdmStorage,
|
|
|
|
mdmStorage,
|
|
|
|
pushFactory,
|
|
|
|
NewNanoMDMLogger(kitlog.NewNopLogger()),
|
|
|
|
)
|
|
|
|
cmdr := NewMDMAppleCommander(mdmStorage, pusher)
|
|
|
|
hostUUID := "ABC-DEF"
|
|
|
|
contents1 := []byte("test-content-1")
|
|
|
|
contents1Base64 := base64.StdEncoding.EncodeToString(contents1)
|
|
|
|
contents2 := []byte("test-content-2")
|
|
|
|
contents2Base64 := base64.StdEncoding.EncodeToString(contents2)
|
|
|
|
|
|
|
|
ds.ListMDMAppleProfilesToInstallFunc = func(ctx context.Context) ([]*fleet.MDMAppleProfilePayload, error) {
|
|
|
|
return []*fleet.MDMAppleProfilePayload{
|
|
|
|
{ProfileID: 1, ProfileIdentifier: "com.add.profile", HostUUID: hostUUID},
|
|
|
|
{ProfileID: 2, ProfileIdentifier: "com.add.profile.two", HostUUID: hostUUID},
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.ListMDMAppleProfilesToRemoveFunc = func(ctx context.Context) ([]*fleet.MDMAppleProfilePayload, error) {
|
|
|
|
return []*fleet.MDMAppleProfilePayload{
|
|
|
|
{ProfileID: 3, ProfileIdentifier: "com.remove.profile", HostUUID: hostUUID},
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.GetMDMAppleProfilesContentsFunc = func(ctx context.Context, profileIDs []uint) (map[uint]fleet.Mobileconfig, error) {
|
|
|
|
require.ElementsMatch(t, []uint{1, 2}, profileIDs)
|
|
|
|
return map[uint]fleet.Mobileconfig{
|
|
|
|
1: contents1,
|
|
|
|
2: contents2,
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
mdmStorage.EnqueueCommandFunc = func(ctx context.Context, id []string, cmd *mdm.Command) (map[string]error, error) {
|
|
|
|
require.NotNil(t, cmd)
|
|
|
|
require.ElementsMatch(t, []string{hostUUID}, id)
|
|
|
|
|
|
|
|
switch cmd.Command.RequestType {
|
|
|
|
case "InstallProfile":
|
|
|
|
if !strings.Contains(string(cmd.Raw), contents1Base64) && !strings.Contains(string(cmd.Raw), contents2Base64) {
|
|
|
|
require.Failf(t, "profile contents don't match", "expected to contain %s or %s but got %s", contents1Base64, contents2Base64, string(cmd.Raw))
|
|
|
|
}
|
|
|
|
case "RemoveProfile":
|
|
|
|
require.Contains(t, string(cmd.Raw), "com.remove.profile")
|
|
|
|
}
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
mdmStorage.RetrievePushInfoFunc = func(ctx context.Context, tokens []string) (map[string]*mdm.Push, error) {
|
|
|
|
res := make(map[string]*mdm.Push, len(tokens))
|
|
|
|
for _, t := range tokens {
|
|
|
|
res[t] = &mdm.Push{
|
|
|
|
PushMagic: "",
|
|
|
|
Token: []byte(t),
|
|
|
|
Topic: "",
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return res, nil
|
|
|
|
}
|
|
|
|
mdmStorage.RetrievePushCertFunc = func(ctx context.Context, topic string) (*tls.Certificate, string, error) {
|
|
|
|
cert, err := tls.LoadX509KeyPair("testdata/server.pem", "testdata/server.key")
|
|
|
|
return &cert, "", err
|
|
|
|
}
|
|
|
|
mdmStorage.IsPushCertStaleFunc = func(ctx context.Context, topic string, staleToken string) (bool, error) {
|
|
|
|
return false, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
ds.BulkUpsertMDMAppleHostProfilesFunc = func(ctx context.Context, payload []*fleet.MDMAppleBulkUpsertHostProfilePayload) error {
|
|
|
|
// TODO: this function is called a second time with a non-empty slice
|
|
|
|
// if there are any errors, test this scenario
|
|
|
|
if len(payload) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
require.ElementsMatch(t, []*fleet.MDMAppleBulkUpsertHostProfilePayload{
|
|
|
|
{
|
|
|
|
ProfileID: 1,
|
|
|
|
ProfileIdentifier: "com.add.profile",
|
|
|
|
HostUUID: hostUUID,
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeInstall,
|
|
|
|
Status: &fleet.MDMAppleDeliveryPending,
|
|
|
|
CommandUUID: payload[0].CommandUUID,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
ProfileID: 2,
|
|
|
|
ProfileIdentifier: "com.add.profile.two",
|
|
|
|
HostUUID: hostUUID,
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeInstall,
|
|
|
|
Status: &fleet.MDMAppleDeliveryPending,
|
|
|
|
CommandUUID: payload[1].CommandUUID,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
ProfileID: 3,
|
|
|
|
ProfileIdentifier: "com.remove.profile",
|
|
|
|
HostUUID: hostUUID,
|
|
|
|
OperationType: fleet.MDMAppleOperationTypeRemove,
|
|
|
|
Status: &fleet.MDMAppleDeliveryPending,
|
|
|
|
CommandUUID: payload[2].CommandUUID,
|
|
|
|
},
|
|
|
|
}, payload)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO(roberto): there's a data race in the mock when more
|
|
|
|
// than one host ID is provided because the pusher uses one
|
|
|
|
// goroutine per uuid to send the commands
|
|
|
|
err := ReconcileProfiles(ctx, ds, cmdr, kitlog.NewNopLogger())
|
2023-02-17 19:26:51 +00:00
|
|
|
require.NoError(t, err)
|
2023-02-22 17:49:06 +00:00
|
|
|
require.True(t, ds.ListMDMAppleProfilesToInstallFuncInvoked)
|
|
|
|
require.True(t, ds.ListMDMAppleProfilesToRemoveFuncInvoked)
|
|
|
|
require.True(t, ds.GetMDMAppleProfilesContentsFuncInvoked)
|
|
|
|
require.True(t, ds.BulkUpsertMDMAppleHostProfilesFuncInvoked)
|
2023-02-17 19:26:51 +00:00
|
|
|
}
|
|
|
|
|
2023-03-01 13:43:15 +00:00
|
|
|
func TestAppleMDMFileVaultEscrowFunctions(t *testing.T) {
|
|
|
|
svc := Service{}
|
|
|
|
|
2023-03-08 13:31:53 +00:00
|
|
|
err := svc.MDMAppleEnableFileVaultAndEscrow(context.Background(), ptr.Uint(1))
|
2023-03-01 13:43:15 +00:00
|
|
|
require.ErrorIs(t, fleet.ErrMissingLicense, err)
|
|
|
|
|
2023-03-08 13:31:53 +00:00
|
|
|
err = svc.MDMAppleDisableFileVaultAndEscrow(context.Background(), ptr.Uint(1))
|
2023-03-01 13:43:15 +00:00
|
|
|
require.ErrorIs(t, fleet.ErrMissingLicense, err)
|
|
|
|
}
|
|
|
|
|
2023-03-03 18:59:21 +00:00
|
|
|
func TestGenerateEnrollmentProfileMobileConfig(t *testing.T) {
|
|
|
|
// SCEP challenge should be escaped for XML
|
|
|
|
b, err := generateEnrollmentProfileMobileconfig("foo", "https://example.com", "foo&bar", "topic")
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Contains(t, string(b), "foo&bar")
|
|
|
|
}
|
|
|
|
|
2023-02-15 18:01:44 +00:00
|
|
|
func mobileconfigForTest(name, identifier string) []byte {
|
|
|
|
return []byte(fmt.Sprintf(`<?xml version="1.0" encoding="UTF-8"?>
|
|
|
|
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
|
|
|
<plist version="1.0">
|
|
|
|
<dict>
|
|
|
|
<key>PayloadContent</key>
|
|
|
|
<array/>
|
|
|
|
<key>PayloadDisplayName</key>
|
|
|
|
<string>%s</string>
|
|
|
|
<key>PayloadIdentifier</key>
|
|
|
|
<string>%s</string>
|
|
|
|
<key>PayloadType</key>
|
|
|
|
<string>Configuration</string>
|
|
|
|
<key>PayloadUUID</key>
|
|
|
|
<string>%s</string>
|
|
|
|
<key>PayloadVersion</key>
|
|
|
|
<integer>1</integer>
|
|
|
|
</dict>
|
|
|
|
</plist>
|
|
|
|
`, name, identifier, uuid.New().String()))
|
|
|
|
}
|