empayre/fleet
14
0
Fork 0
mirror of https://github.com/empayre/fleet.git synced 2024-11-06 17:05:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
a7ae828581
fleet/CODEOWNERS

96 lines
6.7 KiB
Plaintext
Raw Normal View History

Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
##############################################################################################
# ██████╗ ██████╗ ██████╗ ███████╗ ██████╗ ██╗ ██╗███╗ ██╗███████╗██████╗ ███████╗
# ██╔════╝██╔═══██╗██╔══██╗██╔════╝██╔═══██╗██║ ██║████╗ ██║██╔════╝██╔══██╗██╔════╝
# ██║ ██║ ██║██║ ██║█████╗ ██║ ██║██║ █╗ ██║██╔██╗ ██║█████╗ ██████╔╝███████╗
# ██║ ██║ ██║██║ ██║██╔══╝ ██║ ██║██║███╗██║██║╚██╗██║██╔══╝ ██╔══██╗╚════██║
# ╚██████╗╚██████╔╝██████╔╝███████╗╚██████╔╝╚███╔███╔╝██║ ╚████║███████╗██║ ██║███████║
# ╚═════╝ ╚═════╝ ╚═════╝ ╚══════╝ ╚═════╝ ╚══╝╚══╝ ╚═╝ ╚═══╝╚══════╝╚═╝ ╚═╝╚══════╝
##############################################################################################
# ⛔ This file indicates REQUIRED reviewers for changes to certain file paths in this repo.
#
# > How? This "requiredness" is provided natively by GitHub. If a team is specified, then
# > the logic behaves slightly differently. See GitHub's latest documentation on CODEOWNERS
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# > for more information. CODEOWNERS is especially useful for paths that usually end up
# > in PRs with lots of other reviewers.)
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
#
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# ⚠️ For file paths not listed, the DRI is instead indicated in website/config/custom.js.
# Regardless of whether a path's DRI is configured in CODEOWNERS or custom.js, the DRI is
# automatically requested for review when changes are proposed.
# [!] But beware: No path should ever be configured as a DRI in both CODEOWNERS _and_
# the website config.
# [!] In addition, no path should ever be configured in CODEOWNERS if there is ALSO one
# of its ancestral paths configured in website/config/custom.js.
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
#
# ✅ Some paths also have multiple individuals who are allowed to make changes without review,
# even though they are not the DRI. These are called "maintainers".
#
# For more information on how this works, see:
# - What is a DRI and how is this configured? https://fleetdm.com/handbook/company/why-this-way#why-direct-responsibility
# - Historical context: https://github.com/fleetdm/fleet/pull/12786
##############################################################################################
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# 🚀 Golang files and other files related to the core product backend.
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
# (1 or more Golang-literate engineers is required to review changes.)
# FUTURE: Look for a way to not have this notify every single person in this "github team".
##############################################################################################
Add CODEOWNERS for Go engineering team (#1449) This should result in automatic review requests for everyone the @fleetdm/go group when Go or server related files are touched.
2021-07-22 18:14:10 +00:00
*.go @fleetdm/go
go.sum @fleetdm/go
go.mod @fleetdm/go
/server/ @fleetdm/go
/cmd/ @fleetdm/go
Add @edwardsb as codeowner for .tf files (#3969)
2022-02-01 19:59:11 +00:00
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# 🚀 React files and other files related to the core product frontend.
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
# (1 or more React-literate engineers is required to review changes.)
# FUTURE: Look for a way to not have this notify every single person in this "github team".
##############################################################################################
Add frontend group to codeowners (#9542)
2023-01-27 23:35:38 +00:00
/frontend/ @fleetdm/frontend
Add infrastructure directories to codeowners (#12869)
2023-07-20 22:14:01 +00:00
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# 🚀 Config as code for infrastructure, internal security and IT use cases, and more.
Add infrastructure directories to codeowners (#12869)
2023-07-20 22:14:01 +00:00
# (1 or more infra-literate engineers is required to review changes.)
# FUTURE: Look for a way to not have this notify every single person in this "github team".
##############################################################################################
Update infra codeowners (#13079)
2023-08-01 19:03:02 +00:00
/infrastructure/ @fleetdm/infra @edwardsb
/charts/ @fleetdm/infra @edwardsb
/terraform/ @fleetdm/infra @edwardsb
Add infrastructure directories to codeowners (#12869)
2023-07-20 22:14:01 +00:00
Add a few priority CODEOWNERS on top of auto-request automation (#12791)
2023-07-16 02:20:19 +00:00
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# ⚗️ Reference, config surface, built-in queries, API, and other documentation.
Add a few priority CODEOWNERS on top of auto-request automation (#12791)
2023-07-16 02:20:19 +00:00
#
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# (see website/config/custom.js for DRIs of other paths not listed here)
Add a few priority CODEOWNERS on top of auto-request automation (#12791)
2023-07-16 02:20:19 +00:00
##############################################################################################
Make Rachael Shaw CODEOWNER of docs (#15129)
2023-11-15 04:53:49 +00:00
/docs @rachaelshaw
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
/docs/Using-Fleet/REST-API.md @rachaelshaw # « REST API reference documentation
/docs/Contributing/API-for-contributors.md @rachaelshaw # « Advanced / contributors-only API reference documentation
/schema @rachaelshaw # « Data tables (osquery/fleetd schema) documentation
##############################################################################################
# 🫧 Pricing and features
#
# (see website/config/custom.js for DRIs of other paths not listed here)
##############################################################################################
Prepare for rituals.yml automation (move features table YML) (#13049) - Ahead of per-department rituals.yml automation, move feature list .yml out for clarity
2023-08-02 21:58:20 +00:00
/handbook/company/pricing-features-table.yml @mikermcneil # « CEO is current DRI for features table
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
##############################################################################################
# 🦿 Repo automation and change control settings
##############################################################################################
/CODEOWNERS @mikermcneil # See https://github.com/fleetdm/fleet/pull/13195
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
##############################################################################################
# 🦿 Handbook
#
# (see website/config/custom.js for DRIs of other paths not listed here)
##############################################################################################
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
/handbook @mikermcneil # See https://github.com/fleetdm/fleet/pull/13195
fix CODEOWERS and add Desmi as owner of docs/*.md (#6755) Per the new changes in the [handbook](https://fleetdm.com/handbook/community#how-to-request-a-review-for-markdown-changes-to-the-docs) this adds @Desmi-Dizney as codeowner of `docs/*.md`, this way he is automatically added as a reviewer when a file is changed. Since I was there, I also fixed the mention to actually ping @fleetdm/g-platform
2022-07-20 14:51:57 +00:00
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
##############################################################################################
# 🦿 GitHub issue templates
##############################################################################################
/.github/ISSUE_TEMPLATE @mikermcneil # See https://github.com/fleetdm/fleet/pull/13195
Update CODEOWNERS to include handbook, etc (#7163) * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * add articles/ + add leading "/" for CHANGELOG.md so it doesn't inadvertently catch others * Update custom.js * lint fix * Update custom.js
2022-08-11 17:38:00 +00:00
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
# ℹ️ But wait, there's more!
# See the comments up top to learn where else DRIs and maintainers are configured.
Reference in New Issue Copy Permalink